Skip to content

gh-116303: Don't build xxlimited and xxlimited_35 if --disable-test-modules is given#117554

Merged
erlend-aasland merged 1 commit intopython:mainfrom
erlend-aasland:disable-test-modules/disable-xxlimited
Apr 5, 2024
Merged

gh-116303: Don't build xxlimited and xxlimited_35 if --disable-test-modules is given#117554
erlend-aasland merged 1 commit intopython:mainfrom
erlend-aasland:disable-test-modules/disable-xxlimited

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 4, 2024

@erlend-aasland
Copy link
Contributor Author

I consider this a non-controversial change; I'll merge it tomorrow morning.

@erlend-aasland erlend-aasland merged commit 9c1dfe2 into python:main Apr 5, 2024
@erlend-aasland erlend-aasland deleted the disable-test-modules/disable-xxlimited branch April 5, 2024 08:29
@erlend-aasland
Copy link
Contributor Author

We could consider backporting this to 3.12. What do you think, @corona10?

@corona10
Copy link
Member

corona10 commented Apr 5, 2024

Yeah go ahead :)

@erlend-aasland erlend-aasland added the needs backport to 3.12 only security fixes label Apr 5, 2024
@miss-islington-app

This comment was marked as outdated.

@miss-islington-app

This comment was marked as outdated.

@erlend-aasland
Copy link
Contributor Author

Since it does not backport cleanly, I won't bother :)

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants